Handle membership exceptions for synchronized root groups#1587
Open
mirkokg wants to merge 1 commit intoyonaskolb:masterfrom
Open
Handle membership exceptions for synchronized root groups#1587mirkokg wants to merge 1 commit intoyonaskolb:masterfrom
mirkokg wants to merge 1 commit intoyonaskolb:masterfrom
Conversation
Adds logic to detect and register membership exceptions for PBXFileSystemSynchronizedRootGroup objects, specifically excluding Info.plist files from group membership when necessary. Also ensures resources build phase is added if synchronized root groups are present.
Author
|
I also created a PR to fix TEMP_ prefixes for PBXFileSystemSynchronizedBuildFileExceptionSet tuist/XcodeProj#1014 in Xcodeproj, but besides cosmetic problem this issue does not affect XcodeGen negatively. |
Author
|
@yonaskolb please review and let me know if you would change anything. I tested with my projects and all worked perfectly with my version. |
Author
|
@yonaskolb my PR for TEMP_ prefixes is merged now in XcodeProj, can you help with merging this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds logic to detect and register membership exceptions for PBXFileSystemSynchronizedRootGroup objects, specifically excluding Info.plist files from group membership when necessary. Also ensures resources build phase is added if synchronized root groups are present.
I noticed that current implementation of synchronizedGroups does not ignore Info.plist.
I inspected default Xcode behavior and noticed that when you create new Xcode project you get empty copy Resources section:
If this empty PBXResourcesBuildPhase is not present xcassets will not be copied automatically for syncedFolder.
I also noticed that by default it adds Info.plist to ignore list as PBXFileSystemSynchronizedBuildFileExceptionSet:
There are three functionalities implemented with this patch:
This patch fixes an issue with synchronized folders reported by @KieranHarper :
#1586